fix(errors): describe the mutation coordination lock truthfully - #314
Draft
munezaclovis wants to merge 2 commits into
Draft
fix(errors): describe the mutation coordination lock truthfully#314munezaclovis wants to merge 2 commits into
munezaclovis wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
~/.pv/run/update.lockpath and existing lock lifetime unchanged.CoordinationLockHeldacross state, CLI, and daemon paths.Why
Both foreground self-update and daemon reconciliation/update work acquire the same OS lock. The previous error always claimed “PV update is already in progress,” even when reconciliation held it, and could be read as saying the persistent file itself caused contention.
The new wording identifies the exact coordination scope and the active OS lock while leaving mutual exclusion behavior untouched.
Review commits
docs(design): define mutation coordination lock scopefix(errors): use neutral coordination lock wordingChecks
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo nextest run -p state(84 passed)cargo nextest run -p cli --test update --test project_open(46 passed)cargo test -p daemon --lib(108 passed)cargo test -p daemon --test daemon_foundation(30 passed)Closes #308